[wrangler] help with silent success during large asset uploads - #15621
Open
petebacondarwin wants to merge 2 commits into
Open
[wrangler] help with silent success during large asset uploads#15621petebacondarwin wants to merge 2 commits into
petebacondarwin wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 27c1ef0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
jamesopstad
and removed request for
a team
September 12, 2026 11:33
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Contributor
|
LGTM |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #15060.
The asset uploader awaits every queued bucket and requires a completion JWT, so it cannot normally report success with a partial upload count. The reported false-success logs are missing Wrangler's final
✨ Success! Uploaded ...message, which means the CLI stopped beforesyncAssets()completed.This PR fixes two client-side contributors to that failure:
code === null) into exit code 0. It now returns the conventional nonzero128 + signalstatus, preventing OpenNext and Workers Builds from treating a killed deploy as successful.In an isolated 3 x 48 MiB multipart benchmark, the old logging path added about 400 MiB of peak RSS over direct Undici. After this change the same path peaked at 881 MiB versus an 843 MiB direct-Undici control and performed no discarded body conversions. A live 240 MiB upload also confirmed that the queue refilled promptly while active network requests took about 60 seconds each.
This deliberately does not add a fixed per-request timeout. The prior two-minute proposal in #15235 could abort healthy large uploads on slower connections, and the live measurements show that a principled timeout needs separate design. The issue should remain open while the intermittent long-running AUS request path is verified, but this change removes the concrete memory amplifier and makes signal termination fail truthfully.
Note
This is a contribution from an AI agent: Codex (GPT-5).