CC-8654 Make container image build output concise - #15613
Open
skepticfx wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 9beebb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
NuroDev
and removed request for
a team
September 11, 2026 18:32
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
|
LGTM |
nikitassharma
approved these changes
Sep 11, 2026
NuroDev
requested changes
Sep 14, 2026
| output: [null], | ||
| on: (reason: string, cbPassed: (code: number) => unknown) => { | ||
| if (reason === "exit") { | ||
| if (reason === "close") { |
Member
There was a problem hiding this comment.
What's the difference between exit and close here?
| @@ -0,0 +1,38 @@ | |||
| const DEFAULT_MAX_OUTPUT_BYTES = 64 * 1024; | |||
| const DOCKER_DEBUG_HINT = | |||
| "Set WRANGLER_LOG=debug to stream complete Docker output."; | |||
Member
There was a problem hiding this comment.
🔴 We should make this set its env var recommendation dynamically set based on whether this is used by Wrangler of cf CLI.
Comment on lines
+6
to
+8
| export function createBoundedOutputCollector( | ||
| maxBytes = DEFAULT_MAX_OUTPUT_BYTES | ||
| ) { |
Member
There was a problem hiding this comment.
Nit pick: Can we add an explicit return type here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CC-8654
Wrangler now shows compact image progress with elapsed time while hiding successful Docker build, login, tag, and push output. Failures retain bounded diagnostics, and
WRANGLER_LOG=debugrestores live Docker output.