[deploy-helpers] Extract Worker startup profiling from Wrangler - #15612
Open
petebacondarwin wants to merge 9 commits into
Open
[deploy-helpers] Extract Worker startup profiling from Wrangler#15612petebacondarwin wants to merge 9 commits into
petebacondarwin wants to merge 9 commits into
Conversation
🦋 Changeset detectedLatest commit: 2fcf18d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
dario-piotrowicz
and removed request for
a team
September 11, 2026 17:50
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
LGTM! |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
dario-piotrowicz
approved these changes
Sep 14, 2026
| }); | ||
| }); | ||
|
|
||
| describe("summarizeStartupProfile", () => { |
Member
There was a problem hiding this comment.
I can see that you've moved this test to packages/deploy-helpers/tests/startup-profile.test.ts but without the describe block, wouldn't it better to keep it? 🤔
|
|
||
| Share Worker startup profiling with other Cloudflare developer tools | ||
|
|
||
| Move the bundle analyser out of Wrangler so `cf` and deploy failure diagnostics can use the same Miniflare CPU profiler. |
Member
There was a problem hiding this comment.
shall we also mention the deprecation of the analyseBundle arg?
workers-devprod
approved these changes
Sep 14, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for https://github.com/cloudflare/cf/issues/97.
Summary
Wrangler's startup profiler was private to
check startup, socfcould not implement the equivalent command without importing Wrangler internals. This exposes the generic implementation from@cloudflare/deploy-helpers/startup-profile.wrangler check startup, deploy, Pages deploy, and version upload away from Wrangler callback injection.analyseBundleas an optional deprecated compatibility callback.Validation
pnpm --filter @cloudflare/deploy-helpers buildpnpm --filter @cloudflare/deploy-helpers check:typepnpm --filter @cloudflare/deploy-helpers type:testspnpm --filter @cloudflare/deploy-helpers test:ci— 141 testspnpm --filter wrangler buildpnpm --filter wrangler check:typegit diff --check