Prevent internal exception details from reaching JavaScript - #7333
Open
danlapid wants to merge 1 commit into
Open
Prevent internal exception details from reaching JavaScript#7333danlapid wants to merge 1 commit into
danlapid wants to merge 1 commit into
Conversation
Reject diagnostic delimiters in tunneled exception messages, except for the internal-error reference marker. Log blocked exceptions and preserve embedded NULs so serialized errors cannot bypass the check. Reword affected public validation messages and add regression tests. Apply the protection without a compatibility flag to avoid preserving disclosure of internal diagnostics.
|
The generated output of Full Type Diff |
Contributor
|
@danlapid Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject diagnostic delimiters in tunneled exception messages, except for the internal-error reference marker. Log blocked exceptions and preserve embedded NULs so serialized errors cannot bypass the check.
Reword affected public validation messages and add regression tests. Apply the protection without a compatibility flag to avoid preserving disclosure of internal diagnostics.