fix: handle malformed JSX tags with quotes in invalid positions#50
Open
fix: handle malformed JSX tags with quotes in invalid positions#50
Conversation
Fixes issue where single quotes inside malformed JSX attributes would cause MDX parsing errors. The preprocessMdxTags function now detects and escapes such malformed tags by wrapping them in backticks to treat them as literal text. Example: <AccordionNo Documents''> becomes backtick wrapped text 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: H <hkdeman@users.noreply.github.com>
Bug ReportName|Severity|Example test case|Description\n---|---|---|---\nIncorrect handling of escaped backticks inside code blocks|Medium|```\n<Component \`attr\`>\n```|The isInsideCodeBlock function only counts the occurrences of ```. If a code block contains an escaped backtick (\`\`), the function will miscalculate whether the current position is inside a code block. In the example above, the malformed tag <Component \`attr\`> will be incorrectly identified as not being inside a code block. This will lead the regex to incorrectly escape the tag, resulting in double escaping (\`\`<Component \`attr\`>\`\`). Comments? Email us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #49 where single quotes inside malformed JSX attributes would cause MDX parsing errors.
The preprocessMdxTags function now detects and escapes such malformed tags by wrapping them in backticks to treat them as literal text.
Example:
<AccordionNo Documents'">becomes properly escaped textGenerated with Claude Code