Skip to content

Conversation

ccaspanello
Copy link
Contributor

@ccaspanello ccaspanello commented Sep 28, 2025

Description

Fixes #6879

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: Updated SDK model to be consistent with backend API

Summary by CodeRabbit

  • New Features
    • Added an optional organization setting to allow or prevent admin-initiated deletions, configurable via the Organization API.
    • Defaults to existing behavior unless explicitly enabled, so current workflows remain unaffected.

Copy link

changeset-bot bot commented Sep 28, 2025

🦋 Changeset detected

Latest commit: 515d919

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/backend Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 28, 2025

Walkthrough

Updated the exported UpdateParams type in packages/backend/src/api/endpoints/OrganizationApi.ts to include an optional boolean field adminDeleteEnabled. No runtime logic, method implementations, or control flow were changed; a changeset documenting the API addition was added.

Changes

Cohort / File(s) Summary
Organization API types
packages/backend/src/api/endpoints/OrganizationApi.ts
Added optional field adminDeleteEnabled?: boolean to exported UpdateParams type; no other signatures or logic changed.
Release changeset
.changeset/ten-suns-add.md
Documented the API surface change (addition of adminDeleteEnabled to Organization.update) in the patch changeset; no code behavior modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibble on types and tweak a small flag,
A carrot-coded boolean tucked in the bag.
adminDeleteEnabled now hops into view,
One tiny change — the schema's anew.
Thump-thump! A happy rabbit review. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change by indicating that the missing adminDeleteEnabled parameter is being added to the Organization update method in the backend. It clearly conveys the intent without extra noise or irrelevant details.
Linked Issues Check ✅ Passed The changes directly implement the objective from issue #6879 by adding the adminDeleteEnabled optional field to UpdateParams in OrganizationApi, enabling users to set this flag via the SDK without workarounds.
Out of Scope Changes Check ✅ Passed The only modification in this PR is the addition of the adminDeleteEnabled field to the SDK model and no unrelated files or features have been altered, so all changes align with the linked issue’s scope.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2d4e7b0 and 515d919.

📒 Files selected for processing (1)
  • .changeset/ten-suns-add.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/ten-suns-add.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

vercel bot commented Sep 28, 2025

@ccaspanello is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@wobsoriano wobsoriano changed the title UpdateParams in OrganizationApi is missing adminDeleteEnabled chore(backend): Add missing adminDeleteEnabled param to Organization update method Oct 7, 2025
Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jacekradko jacekradko merged commit fe873dc into clerk:main Oct 8, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdateParams in OrganizationApi is missing adminDeleteEnabled
4 participants