Prevent delete/rename of checked-out branches, add --force to detach#5
Merged
Conversation
…ag cleanup - In cmdRename, move conflict check before checkBranchesNotCheckedOut so a failed rename doesn't leave the user in detached HEAD state - Use defer to reset forceFlag in tests so it's always cleaned up even on early failure Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
branchesPreflight() is now side-effect-free: it checks worktrees and the current branch, returning the branch to detach (or "") without touching repo state. Callers detach HEAD immediately before the first mutating operation, after all validation and user confirmation. Also: fail closed on git symbolic-ref and git worktree list errors instead of silently proceeding with empty/stale state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot instructions: