-
Notifications
You must be signed in to change notification settings - Fork 164
Bump typelit plugins #3061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bump typelit plugins #3061
Conversation
|
Could you also locally run a check with |
Every build is currently failing due to warnings caused by clash-lang/ghc-typelits-natnormalise#105 (comment). I created another branch for just checking the changes to |
9934ba6 to
f526cab
Compare
| ghc-typelits-extra >= 0.5.1 && < 0.6, | ||
| ghc-typelits-knownnat >= 0.8.2 && < 0.9, | ||
| ghc-typelits-natnormalise >= 0.9.1 && < 0.10, | ||
| -- <<< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the new code in Vector.hs doesn't typecheck with the old version of the plugin(s), the lower bound increases should be permanant.
But possibly conditional on the GHC version.
f526cab to
865be36
Compare
|
I’m adding some features and fixes in clash-lang/ghc-typelits-natnormalise#110 which will hopefully only require haddock/doctest changes w.r.t. error messages for |
|
With the changes in clash-lang/ghc-typelits-natnormalise#110, the following is all that's needed to compile clash-prelude warning-free and pass the unit-tests and doctests: 9b4ca8a |
865be36 to
10d8484
Compare
I note you don't increase the lower bounds on the dependencies. So does it work with the whole range of versions in the interval then? I'm having trouble understanding how you fix a compilation error by merely allowing more versions of a dependency to be used... [edit] |
10d8484 to
7e907a9
Compare
That's great. Thanks. I'd wait a bit more to also include the next |
The PR bumps
ghc-typelits-natnormalise,ghc-typelits-knownnat, andghc-typelits-extrato the latest versions and introduces some required code changes inclash-preludeto make it compile.Still TODO:
Requires Bump typelit plugins (preparations) #3062obsolete due to Derive new givens ghc-typelits-natnormalise#110Winaccessible-codeorWincomplete-patternsghc-typelits-natnormalise#109Nice to have:
CLogtype family reduction #3078