Skip to content

Drop @joyid/ckb: core and joy-id use two small helpers from it #595

Description

@LusoCryptoLabs

@ckb-ccc/core uses @joyid/ckb only for verifySignature (verifyJoyId.ts), and @ckb-ccc/joy-id only for Aggregator.generateSubkeyUnlockSmt (ckb/index.ts). The first is WebCrypto, the second is one JSON-RPC call.

@joyid/ckb imports @nervosnetwork/ckb-sdk-utils, a CJS module that loads elliptic at import, so apps bundle it: ckb-sdk-utils 0.109.5 with its dependencies is 194 KB minified (67 KB gzip). It also brings 21 low npm audit notes in an app with the connector (GHSA-848j-6mx2-7j84, no patched elliptic). That advisory is about signing, which these paths never do.

Would a PR that inlines both be welcome?

Activity

  1. added theissue type on Oct 10, 2026
  2. changed the issue type fromtoon Oct 10, 2026
  3. Hanssen0 commented on Oct 10, 2026

    @Hanssen0
    Member

    Hi @LusoCryptoLabs! Thank you for sharing your finding, and yes, the outdated dependency is worth refactoring. We would certainly welcome it if you were willing to create a PR for this!

  4. changed the issue type fromtoon Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency fileenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions