Resolves session conflict when working with multiple browser tabs. See #6625

[AlainBenbassat]

Overview

Editing and saving memberships across multiple browser tabs concurrently can result in the accidental deletion of an existing membership. See https://lab.civicrm.org/dev/core/-/work_items/6625

Before

See https://lab.civicrm.org/dev/core/-/work_items/6625

After

Fixes this bug.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

PR commands & links...

• /rebase <branch-name> will rebase your branch and change the base of the PR.
• /squash will combine all commits (keeping only the first commit messsage).
• /port <branch-name> will create a copy of this PR against a different branch.
• /lintroll will automatically fix linting errors, amending commits as needed.
• retest this please will rerun the tests and rebuild the demo site.
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

/lintroll

[seamuslee001]

Test fail seems to be related here

[AlainBenbassat]

@seamuslee001 It's not clear to me what's causing this failure. Do you have a clue?

[demeritcowboy]

I believe the test is saying that if the url only contains id then that's a valid call, and this change then breaks any workflow that makes links to the form with id in the url but doesn't have action=update in the url.

The id is stored in the session, which on its own isn't bad, but the two forms end up pointing to the same session data even though they are completely different forms. I'm not sure of a quick fix.