fix: Prevent hidden events from disrupting timeline date separators and message grouping - #3093
Open
Yashh56 wants to merge 1 commit into
Open
fix: Prevent hidden events from disrupting timeline date separators and message grouping#3093Yashh56 wants to merge 1 commit into
Yashh56 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the timeline would sometimes render multiple duplicate Date Separators on the same day. It also fixes a related visual issue where consecutive messages sent by the same user within a minute would fail to collapse (group together) and erroneously repeat the user's avatar.
The root cause was that hidden events (such as
m.reactionor edits) were continually updating theprevEventreference as they were processed. Because they are not rendered on screen, any date boundaries they crossed would leave thedayDividerstate stuck astruefor the next visible message. Furthermore, their presence between normal messages disrupted the sender matching in thecollapsedgrouping check.Changes
prevRenderedEventinRoomTimeline.tsxto strictly track the last visible event rendered in the timeline block.dayDividerandcollapsedlogic to evaluate againstprevRenderedEventinstead ofprevEvent.prevEventis still maintained for other underlying logic, such as determining the read-receiptnewDividermarker.Close: #3071