[Snyk] Security upgrade mermaid from 11.5.0 to 11.12.1 - #89
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-DAGRED3ES-13110069
|
|
Summary of ChangesHello @arthrod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, upgrades the mermaid package to version 11.12.1 to resolve a security vulnerability. While this is a necessary update, it's important to note that it also updates several transitive dependencies. One of these, marked, is updated to a version that requires Node.js 20 or higher. Your project currently supports Node.js 18, which could lead to compatibility issues. I've added a specific comment highlighting this potential problem.
| "engines": { | ||
| "node": ">= 18" | ||
| "node": ">= 20" | ||
| } |
There was a problem hiding this comment.
The marked package, a transitive dependency of mermaid, has been updated to a version that requires Node.js 20 or higher. Your project's package.json specifies a Node.js version range of >=18.13.0 <=22.x.x, which could lead to compatibility issues in environments running Node.js 18. It is recommended to either update your project's Node.js requirement to >=20 or use npm overrides to force a compatible version of marked for mermaid.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "node_modules/mermaid/node_modules/marked": { | ||
| "version": "15.0.7", | ||
| "resolved": "https://registry.npmjs.org/marked/-/marked-15.0.7.tgz", | ||
| "integrity": "sha512-dgLIeKGLx5FwziAnsk4ONoGwHwGPJzselimvlVskE9XLN4Orv9u2VA3GWw/lYUqjfA0rUT/6fqKwfZJapP9BEg==", | ||
| "version": "16.4.2", | ||
| "resolved": "https://registry.npmjs.org/marked/-/marked-16.4.2.tgz", | ||
| "integrity": "sha512-TI3V8YYWvkVf3KJe1dRkpnjs68JUPyEa5vjKrp1XEEJUAOaQc+Qj+L1qWbPd0SJuAdQkFU0h73sXXqwDYxsiDA==", | ||
| "license": "MIT", | ||
| "bin": { | ||
| "marked": "bin/marked.js" | ||
| }, | ||
| "engines": { | ||
| "node": ">= 18" | ||
| "node": ">= 20" | ||
| } |
There was a problem hiding this comment.
Align engine support with mermaid's Node 20 dependency
The upgrade to mermaid@11.12.1 pulls in marked@16.4.2, which declares an engine requirement of node >= 20 (package-lock.json lines 8033‑8043). The project still advertises support for Node >=18.13 in package.json, so developers following the documented minimum will hit engine errors (pnpm/engine‑strict) or run code compiled for newer runtime features. Either raise the documented Node requirement to 20 or stay on a mermaid release whose transitive dependencies still support Node 18.
Useful? React with 👍 / 👎.
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonpackage-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-DAGRED3ES-13110069
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution