Skip to content

fixed incompatibility on node 4.1.0 on windows. - #97

Open
bunnybones1 wants to merge 1 commit into
chrisdickinson:masterfrom
bunnybones1:master
Open

fixed incompatibility on node 4.1.0 on windows.#97
bunnybones1 wants to merge 1 commit into
chrisdickinson:masterfrom
bunnybones1:master

Conversation

@bunnybones1

Copy link
Copy Markdown

I couldn't run beefy on node 4.1.0 on Windows because of something they changed in Buffer.concat. This change resolves the following error:


beefy (v2.1.5) is listening on http://127.0.0.1:9966
200    7ms       530B  / (generated)
buffer.js:229
    buf.copy(buffer, pos);
        ^

TypeError: buf.copy is not a function
    at Function.Buffer.concat (buffer.js:229:9)
    at Stream.end (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\lib\accumulate-error.js:25:26)
    at _end (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:61:9)
    at Stream.stream.end (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:70:5)
    at Stream.onend (stream.js:59:10)
    at emitNone (events.js:72:20)
    at Stream.emit (events.js:166:7)
    at drain (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:33:23)
    at Stream.stream.queue.stream.push (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:41:5)
    at Stream.end (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:17:35)
npm ERR! Test failed.  See above for more details.

@latentflip

Copy link
Copy Markdown

This is not just a windows issue, fairly sure this affects all platforms (certainly keeps breaking for me on osx now that I'm using node 4).

@shobhitg

Copy link
Copy Markdown

Same issue with Mac osx Yosemite and Node v5.0.0

@dcosson

dcosson commented Dec 7, 2015

Copy link
Copy Markdown

I get this issue as well.

EDIT: opened a new issue #99 since it seems much broader than a minor incompatibility on Windows

@jacob-meacham

Copy link
Copy Markdown

👍 for this issue - it's causing downstream problems with stackgl projects (especially shader-school and webgl-workshop)

@yocontra

Copy link
Copy Markdown

Any reason this hasn't been merged?

@heckj

heckj commented Dec 29, 2015

Copy link
Copy Markdown

another request please for merging this - hitting the same issue with errors crashing the beefy server running my dev instance

@refractalize

Copy link
Copy Markdown

LGTM

@okdistribute

Copy link
Copy Markdown

Yes, is also a problem on mac

@davidpoxon

Copy link
Copy Markdown

I bootcamp Windows 10 and OS X El Capitan and have this problem on both systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants