fixed incompatibility on node 4.1.0 on windows. - #97
Open
bunnybones1 wants to merge 1 commit into
Open
Conversation
|
This is not just a windows issue, fairly sure this affects all platforms (certainly keeps breaking for me on osx now that I'm using node 4). |
|
Same issue with Mac osx Yosemite and Node v5.0.0 |
|
I get this issue as well. EDIT: opened a new issue #99 since it seems much broader than a minor incompatibility on Windows |
|
👍 for this issue - it's causing downstream problems with stackgl projects (especially shader-school and webgl-workshop) |
|
Any reason this hasn't been merged? |
|
another request please for merging this - hitting the same issue with errors crashing the beefy server running my dev instance |
|
LGTM |
|
Yes, is also a problem on mac |
|
I bootcamp Windows 10 and OS X El Capitan and have this problem on both systems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't run beefy on node 4.1.0 on Windows because of something they changed in
Buffer.concat. This change resolves the following error: