Skip to content

fix: reference KEN_ALL.CSV with correct case so the rake task works on Linux#86

Merged
chocoby merged 1 commit into
mainfrom
fix-zip-code-data-csv-filename-case
Jul 23, 2026
Merged

fix: reference KEN_ALL.CSV with correct case so the rake task works on Linux#86
chocoby merged 1 commit into
mainfrom
fix-zip-code-data-csv-filename-case

Conversation

@chocoby

@chocoby chocoby commented Jul 23, 2026

Copy link
Copy Markdown
Owner

概要

  • create_zip_code_data タスクが Linux 上で失敗する問題を修正
  • 日本郵便の ken_all.zip に含まれる CSV は KEN_ALL.CSV (大文字) だが、Rakefile は ken_all.csv (小文字) を参照していた
  • macOS はファイル名の大文字小文字を区別しないためローカルでは動作していたが、大文字小文字を区別する Linux (GitHub Actions) では iconv がファイルを見つけられず失敗していた

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same — fix-zip-code-data-csv-filename-case into main

@chocoby
chocoby marked this pull request as ready for review July 23, 2026 00:14
@chocoby
chocoby merged commit aa5a83d into main Jul 23, 2026
52 checks passed
@chocoby
chocoby deleted the fix-zip-code-data-csv-filename-case branch July 23, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants