Merged
Conversation
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Adjust interface for use in DMOD_MODULE mode
Add DMOD_MODULE mode support to dmosi
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dmosi was only usable in
DMOD_SYSTEMmode. Modules needing OS interface access had no way to link against dmosi without pulling in the full system-mode implementation. This follows the pattern established in dmlist.CMakeLists.txt
${DMOD_DIR}/paths.cmaketo resolveDMOD_SYSTEM/DMOD_MODULEbooleansdmosi_ifINTERFACE library exposing only the include directory — linkable by modules in any build modedmosiSTATIC library (implementation, compile definitions, coverage, makefile generation) underif(DMOD_SYSTEM)CI Workflow
DMOD_MODULEmode build leg (-DDMOD_MODE=DMOD_MODULE) that verifieslibdmosi.ais not produced (only the interface target is built in module mode)Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.