Skip to content

Add automatic DMOD fetching when DMOD_DIR is not provided#14

Merged
JohnAmadis merged 10 commits intomasterfrom
copilot/add-fetch-dmod-when-dir-not-provided
Dec 28, 2025
Merged

Add automatic DMOD fetching when DMOD_DIR is not provided#14
JohnAmadis merged 10 commits intomasterfrom
copilot/add-fetch-dmod-when-dir-not-provided

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 28, 2025

Plan: Add automatic DMOD fetching when DMOD_DIR is not provided

  • Understand current DMOD fetching mechanism in release workflow
  • Modify CMakeLists.txt to use FetchContent to fetch DMOD when DMOD_DIR is not set
  • Ensure backward compatibility - keep existing behavior when DMOD_DIR is explicitly set
  • Update Makefile to support fetching DMOD
  • Update examples/ramfs/Makefile with same fetching logic
  • Add .dmod directory to .gitignore
  • Test CMake build without DMOD_DIR set
  • Test Makefile build without DMOD_DIR set
  • Update documentation
  • Add CI jobs to test automatic fetching
  • Address code review feedback - improve error handling and simplify code
  • Improve variable naming conventions
  • Fix FetchContent syntax in CMake
  • Simplify environment variable handling in Makefiles
  • Remove accidentally committed test artifacts
  • Remove deprecated FetchContent_GetProperties
  • Add explicit error checking to Makefile shell commands
  • Add explicit permissions to CI workflow jobs
  • Fix CI build failures
    • Added -DDMOD_MODE=DMOD_MODULE to CMake build to generate DMF files
    • Fixed sed error in Make by using _unused variable instead of named output variables

Summary

Successfully implemented automatic DMOD fetching when DMOD_DIR is not provided. Both CMake and Make build systems now automatically fetch and build DMOD from git when needed, while maintaining full backward compatibility with existing workflows that provide DMOD_DIR explicitly. All CI builds are now passing.

Original prompt

This section details on the original issue you should resolve

<issue_title>dodać fetchowanie dmod jeśli DMOD_DIR jest niepodany</issue_title>
<issue_description>Jeśli DMOD_DIR nie jest podany, to powinniśmy sfetchować dmod</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 7 commits December 28, 2025 16:29
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
@JohnAmadis JohnAmadis marked this pull request as ready for review December 28, 2025 16:40
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot AI changed the title [WIP] Add fetch for dmod when DMOD_DIR is not provided Add automatic DMOD fetching when DMOD_DIR is not provided Dec 28, 2025
Copilot AI requested a review from JohnAmadis December 28, 2025 16:43
@JohnAmadis
Copy link
Copy Markdown
Contributor

@copilot build failuje
logs_53138199596.zip

Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Dec 28, 2025

@copilot build failuje
logs_53138199596.zip

Fixed in commit 520ae41. Two issues were resolved:

  1. CMake build: Added -DDMOD_MODE=DMOD_MODULE flag to generate DMF files instead of static libraries
  2. Make build: Fixed sed error by using _unused variable instead of named output variables that were being cached and causing sed to fail with special characters

Both builds should now pass successfully.

@JohnAmadis JohnAmadis merged commit c7093a9 into master Dec 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dodać fetchowanie dmod jeśli DMOD_DIR jest niepodany

2 participants