Skip to content

fix: general settings save / apply - #3982

Merged
tpoisseau merged 3 commits into
mainfrom
3980-fix-form-submission
Feb 16, 2026
Merged

fix: general settings save / apply#3982
tpoisseau merged 3 commits into
mainfrom
3980-fix-form-submission

Conversation

@tpoisseau

@tpoisseau tpoisseau commented Feb 16, 2026

Copy link
Copy Markdown
Contributor
fix: general settings save / apply (#3982)

merge currentWorkspace with form values for type safety and not loose values not yet supported by the form.

Closes: https://github.com/cheminfo/nmrium/issues/3980

refactor: split validation to files by tab (#3982)

refactor: rename import `.ts{x}` to `.js` (#3982)

@tpoisseau tpoisseau linked an issue Feb 16, 2026 that may be closed by this pull request
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Feb 16, 2026

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: eae3e22
Status: ✅  Deploy successful!
Preview URL: https://d5a949e3.nmrium.pages.dev
Branch Preview URL: https://3980-fix-form-submission.nmrium.pages.dev

View logs

merge currentWorkspace with form values for type safety and not loose values not yet supported by the form.

Closes: #3980

refactor: rename import `.ts{x}` to `.js`
@tpoisseau
tpoisseau marked this pull request as ready for review February 16, 2026 10:03
@tpoisseau tpoisseau changed the title refactor: split validation to files by tab fix: general settings save / apply Feb 16, 2026

@Sebastien-Ahkrin Sebastien-Ahkrin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpoisseau
tpoisseau merged commit 630c7f3 into main Feb 16, 2026
14 of 15 checks passed
@tpoisseau
tpoisseau deleted the 3980-fix-form-submission branch February 16, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix form submission

2 participants