Skip to content

refactor: change header to use zod and new form - #3957

Merged
Sebastien-Ahkrin merged 21 commits into
mainfrom
refactor-header-dialog
Feb 6, 2026
Merged

refactor: change header to use zod and new form#3957
Sebastien-Ahkrin merged 21 commits into
mainfrom
refactor-header-dialog

Conversation

@Sebastien-Ahkrin

Copy link
Copy Markdown
Collaborator

No description provided.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Feb 2, 2026

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 97692b5
Status: ✅  Deploy successful!
Preview URL: https://78947881.nmrium.pages.dev
Branch Preview URL: https://refactor-header-dialog.nmrium.pages.dev

View logs

@Sebastien-Ahkrin
Sebastien-Ahkrin marked this pull request as ready for review February 2, 2026 15:27
@Sebastien-Ahkrin

Sebastien-Ahkrin commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator Author

Care, the func' isn't perfectly working ... Its only a good base to check if values are correctly binded between the two forms

Comment thread src/component/header/Header.tsx Outdated
Comment thread src/component/modal/setting/tanstack_general_settings/validation/utils.ts Outdated
Comment thread src/component/modal/setting/tanstack_general_settings/general_settings.tsx Outdated
Comment thread src/component/modal/setting/tanstack_general_settings/general_settings.tsx Outdated
Comment thread src/component/modal/setting/tanstack_general_settings/general_settings.tsx Outdated
Comment thread src/component/modal/setting/tanstack_general_settings/general_settings.tsx Outdated
@Sebastien-Ahkrin
Sebastien-Ahkrin marked this pull request as draft February 3, 2026 15:39
@Sebastien-Ahkrin
Sebastien-Ahkrin marked this pull request as ready for review February 6, 2026 12:21

@tpoisseau tpoisseau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments bellow are not blocking to merge the PR. If you prefer take them into account later, please create sub issues to not forgot them.

Parrent issue: #3932

Comment thread src/component/modal/setting/tanstack_general_settings/validation.ts
@Sebastien-Ahkrin
Sebastien-Ahkrin merged commit e879a80 into main Feb 6, 2026
12 checks passed
@Sebastien-Ahkrin
Sebastien-Ahkrin deleted the refactor-header-dialog branch February 6, 2026 15:15
@tpoisseau tpoisseau linked an issue Feb 16, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspace picker and controls

2 participants