-
-
Notifications
You must be signed in to change notification settings - Fork 115
feat: Introduce cross-core testing along with improvements to test frameworking #7524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e80f2e5 to
a487d66
Compare
iequidoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but better if some Python expert approves this
|
On Thu, Nov 27, 2025 at 12:31 -0800, l wrote:
Maybe `Scripts` always, work, on non-windows as well?
No, on non-windwos virtualenv directories only have "bin"
|
…hat-rpc-client is used
Co-authored-by: iequidoo <[email protected]>
b3cd7b9 to
2925fad
Compare
|
I will force-push on the main to fix the commits. Don't know if there is a way to force "conventional commits" on the main branch in CI. We currently allow to merge using rebase-merging and squash-merging and merge commit merging assuming that whoever merges knows how they want to merge, but then when you squash-merge you need to check that PR description is correct and if you rebase-merge you need to check that commits are correct so what is merged is not "Update README.md" commits and not the PR description in case when PR description is not conventional commits. But also when someone squash-merges you sometimes get this, commit messages with checklist, github-hosted images etc: |

also
deltachat-rpc-server: PATH [VERSION]is shown in pytest run headers.addresses #7428