Skip to content

Conversation

@hpk42
Copy link
Contributor

@hpk42 hpk42 commented Nov 25, 2025

also deltachat-rpc-server: PATH [VERSION] is shown in pytest run headers.

addresses #7428

Copy link
Collaborator

@iequidoo iequidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but better if some Python expert approves this

@hpk42
Copy link
Contributor Author

hpk42 commented Nov 28, 2025 via email

@hpk42 hpk42 changed the title Introduce cross-core testing along with improvements to test frameworking feat: Introduce cross-core testing along with improvements to test frameworking Nov 30, 2025
@hpk42 hpk42 merged commit 66c2b1c into main Dec 4, 2025
29 checks passed
@hpk42 hpk42 deleted the hpk/cross-core2 branch December 4, 2025 14:14
@link2xt
Copy link
Collaborator

link2xt commented Dec 4, 2025

image

:(

@link2xt
Copy link
Collaborator

link2xt commented Dec 4, 2025

I will force-push on the main to fix the commits.

Don't know if there is a way to force "conventional commits" on the main branch in CI. We currently allow to merge using rebase-merging and squash-merging and merge commit merging assuming that whoever merges knows how they want to merge, but then when you squash-merge you need to check that PR description is correct and if you rebase-merge you need to check that commits are correct so what is merged is not "Update README.md" commits and not the PR description in case when PR description is not conventional commits. But also when someone squash-merges you sometimes get this, commit messages with checklist, github-hosted images etc:
0a73c2b
0d8c2ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants