fix: use pty aware charmbracelet/ssh#219
Closed
aymanbagabas wants to merge 4 commits intousing-ptyfrom
Closed
Conversation
aymanbagabas
force-pushed
the
using-pty-update
branch
4 times, most recently
from
be35f67 to
154af23
Compare
aymanbagabas
force-pushed
the
using-pty-update
branch
from
154af23 to
7ca8c0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## using-pty #219 +/- ##
==========================================
Coverage 76.40% 76.40%
==========================================
Files 17 17
Lines 907 907
==========================================
Hits 693 693
Misses 160 160
Partials 54 54 ☔ View full report in Codecov by Sentry. |
caarlos0
reviewed
Jan 8, 2024
Contributor
caarlos0
left a comment
caarlos0
left a comment
There was a problem hiding this comment.
I'll rebase these changes manually as it's conflicted now
Thanks for the PR 🙏
caarlos0
added a commit
that referenced
this pull request
Jan 8, 2024
based on #219 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
aymanbagabas
force-pushed
the
using-pty-update
branch
from
0fce6d4 to
bf2f028
Compare
Contributor
|
merged manually in 50a706e |
caarlos0
added a commit
that referenced
this pull request
Jan 18, 2024
* feat: use pty Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: deps Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: deps Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: update example * fix: deps * docs: fix example * feat: pass lipgloss.Renderer down to the tea.App * fix: go mod tidy Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * improvements Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: pty Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com> Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: better diff * chore: typo * fix: godocs * fix: allocate pty on macos Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: improvements based on #219 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com> * chore: godoc * fix: review Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com> Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: example Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: tea program handler Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: examples * refactor: improve p!=nil handling Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: ensure session envs are available to renderer (#223) * fix: rename func to makeoptions * fix: not too much breaking * chore: fix gitignore * fix: dep Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: update charmbracelet/ssh * fix: update dep Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: go mod tidy Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: update example --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on charmbracelet/ssh#8