testsuite: complete sharness framework conversion #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the kern/t14 statfs is duplicated in t0010-v9fs-runasuser.t. Drop the old test.
Problem: the kern/t45 pathwalk test lives in the old test framework. Migrate to sharness.
Problem: the kern/t16 stat test is duplicated in t0010-v9fs-runasuser.t. Drop the old test.
Problem: kern/tsuppgrp.c has no users. Drop it.
Problem: the kern/t25 setgroupid directory test lives in the old test framework. Create a new test in t0012-v9fs-multiuser.t. Drop the old one.
Problem: the kern/t13 rename test is duplicated in t0010-v9fs-runasuser.t. Drop the old test.
grondo
approved these changes
Oct 31, 2025
Member
grondo
left a comment
grondo
left a comment
There was a problem hiding this comment.
LGTM. Just a few commit message typos.
| test_tattach \ | ||
| test_loadgen \ | ||
| test_pathwalk \ | ||
| test_flock \ |
Member
There was a problem hiding this comment.
Commit message typo: 'the ... test live' -> ' the ... tests live'
| --debug=0x1 \ | ||
| --export=$exportdir | ||
|
|
||
| if PATH_GETFATTR=$(which getfattr) && PATH_SETFATTR=$(which setfattr); then |
Member
There was a problem hiding this comment.
Commit message: "kern/42" should be "kern/t42" I assume.
Also duplicate "test" at end of line 1.
Comment on lines
-48
to
-49
| - name: check with linux/9p | ||
| run: sudo make check -C tests/kern |
Problem: the kern/t18 and t24 flock tests live in the old test framework. Create new tests in t0010-v9fs-runasuser.t. Drop the old ones.
Problem: the kern/t42, t46, and t47 extended attribute tests live in the old test framework. Create new tests in t0012-v9fs-multiuser.t. Drop the old ones.
Problem: the kern/t12 create-with-mode test lives in the old test framework. Create a new test in t0010-v9fs-runasuser.t. Drop the old one.
Problem: the kern/t44 atomic create test lives in the old test framework. Create a new test in t0010-v9fs-runasuser.t. Drop the old one.
Problem: the kern/t15 fsync test is duplicated in t0010-v9fs-runasuser.t. Drop the old test.
Problem: the kern/t17 mode test is duplicated in t0010-v9fs-runasuser.t. Drop the old test.
Problem: fstest, fsstress, and fsx are vendored tests that appear to be abandoned or at least not widely used. Drop for now.
Problem: the .gitignore names a bunch of files and directories that no longer exist. Remove them.
Problem: tests/kern has been removed but the github workflow still tries to run it. Don't do that.
Problem: compilation fails on debian 12/aarch64:
diodcli.c: In function ‘print_stat’:
diodcli.c:838:66: error: format ‘%lu’ expects argument of type
‘long unsigned int’, but argument 7 has type ‘__blksize_t’
{aka ‘int’} [-Werror=format=]
diodcli.c:838:13: error: format ‘%lu’ expects argument of type
‘long unsigned int’, but argument 8 has type ‘__nlink_t’
{aka ‘unsigned int’} [-Werror=format=]
Add a cast.
Problem: apparently raspbian doesn't configure v9fs with 9P_FS_SECURITY, so the xattr tests on the "security." prefix fail with "Operation not supported". Add a SECURITY test prereq so these tests are skipped by default. Later we can look into how to automatically enable them when the feature is available.
Member
Author
|
Thanks! fixed those things and also tacked on a couple of minor fixes from retesting on rasbian. I'll set MWP. |
Member
Author
|
Oh this changed the github workflow so might need a manual merge. I'll press the button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the project's conversion to the sharness test framework.
I did drop three test suites: fsx, fstest, and fsstress. These projects are old and don't seem to be well supported, and in the past when we've had test failures, it has been a total pain to interpret what has gone wrong. I'd rather give them up and start fresh. We can pull in other tests as modern, supported ones are identified.