fix: dont fail on unresolved registry packages #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
requested review from
brentleyjones,
cgrindel and
jpsim
as code owners
cgrindel
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1223 but for registry packages, let's users run
@swift_package//:resolvewithout crashing with:ERROR: /private/var/tmp/_bazel_lpadron/0ee4409da52ac4ece68cb8fe68c1de00/external/rules_swift_package_manager+/swiftpkg/bzlmod/swift_deps.bzl:273:34: Traceback (most recent call last): File "/private/var/tmp/_bazel_lpadron/0ee4409da52ac4ece68cb8fe68c1de00/external/rules_swift_package_manager+/swiftpkg/bzlmod/swift_deps.bzl", line 315, column 43, in _swift_deps_impl _declare_pkgs_from_package( File "/private/var/tmp/_bazel_lpadron/0ee4409da52ac4ece68cb8fe68c1de00/external/rules_swift_package_manager+/swiftpkg/bzlmod/swift_deps.bzl", line 188, column 37, in _declare_pkgs_from_package _declare_pkg_from_dependency(dep, config_pkg, from_package, config_swift_package) File "/private/var/tmp/_bazel_lpadron/0ee4409da52ac4ece68cb8fe68c1de00/external/rules_swift_package_manager+/swiftpkg/bzlmod/swift_deps.bzl", line 273, column 34, in _declare_pkg_from_dependency id = dep.registry.pin.identity, Error: 'NoneType' value has no field or method 'identity'