Skip to content

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Jun 17, 2025

Contributor Agreement

By submitting this pull request, I affirm that:

  • I have reviewed, fully understand, and agree to abide by the terms of the Contributor License Agreement detailed in CONTRIBUTING.md.

@laskoviymishka
Copy link
Contributor

Thanks for your contributions!

It's a bit rude question, but is it possible to split this one in stacked pr so it would be easier to review?

Copy link
Contributor

@laskoviymishka laskoviymishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, once this couple tiny piece are done - safe to merge.


// ApplyCORSHeaders adds the standard CORS headers to a response
// For handlers that are not wrapped in middleware
func ApplyCORSHeaders(w http.ResponseWriter, allowedMethods string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cors.ApplyCORSHeaders -> cors.ApplyHeaders

@laskoviymishka laskoviymishka merged commit b355006 into centralmind:main Jul 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants