Skip to content

chore(deps): update module gopkg.in/evanphx/json-patch.v4 to v5 - #498

Open
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x
Open

chore(deps): update module gopkg.in/evanphx/json-patch.v4 to v5#498
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x

Conversation

@red-hat-konflux-kflux-prd-rh02

@red-hat-konflux-kflux-prd-rh02 red-hat-konflux-kflux-prd-rh02 Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
gopkg.in/evanphx/json-patch.v4 v4.13.0v5.9.11 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

evanphx/json-patch (gopkg.in/evanphx/json-patch.v4)

v5.9.11

Compare Source

What's Changed

Full Changelog: evanphx/json-patch@v5.9.10...v5.9.11

v5.9.10

Compare Source

What's Changed

New Contributors

Full Changelog: evanphx/json-patch@v5.9.0...v5.9.10

v5.9.0

Compare Source

What's Changed

Full Changelog: evanphx/json-patch@v5.8.1...v5.9.0

v5.8.1: Fix API breakage

Compare Source

This PR fixes Operation containing a reference to internal/json and breaking the ability to manually compose one. This restores that ability using a type alias.

Full Changelog: evanphx/json-patch@v5.8.0...v5.8.1

v5.8.0: Blargh Phixs and Empathyprovements

Compare Source

This release fixes a few stray panics, addresses large number accuracy, and improves performance!

What's Changed

Full Changelog: evanphx/json-patch@v5.7.0...v5.8.0

v5.7.0: The 2023 Release

Compare Source

What's Changed

New Contributors

Full Changelog: evanphx/json-patch@v5.6.0...v5.7.0

v5.6.0: Bug fixes

Compare Source

What's Changed

New Contributors

Full Changelog: evanphx/json-patch@v5.5.0...v5.6.0

v5.5.0: Better null handling

Compare Source

This incorporates a few fixes related to how nulls are handles in array's and objects.

v5.3.0: Fix zero sized document crash

Compare Source

This fixes a crash bug where submitted an empty slice as the document would panic.

v5.2.0

Compare Source

v5.1.0

Compare Source

v5.0.0: Proper Go modules release

Compare Source

This release has a proper /v5 directory, unlike the previous releases that did not have a /v4 dir. Thanks to @​BenTheElder for getting this sorted out!


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux-kflux-prd-rh02

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: mod upgrade --mod-name=gopkg.in/evanphx/json-patch.v4 -t=5
could not load package: err: exit status 1: stderr: go: inconsistent vendoring in /tmp/renovate/repos/github/centos-automotive-suite/automotive-dev-operator:
	gopkg.in/evanphx/json-patch.v5@v5.9.11: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor


@ambient-code

ambient-code Bot commented Aug 7, 2026

Copy link
Copy Markdown

MintMaker PR Review

Package: gopkg.in/evanphx/json-patch.v4 v4.13.0 → gopkg.in/evanphx/json-patch.v5 v5.9.11

go.mod changes

This PR modifies go.mod only (only one Go module in the repo, no sub-projects affected).

CI Status

❌ CI is failing with:

go: inconsistent vendoring:
  gopkg.in/evanphx/json-patch.v5@v5.9.11: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
  gopkg.in/evanphx/json-patch.v4@v4.13.0: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod

Also: renovate/artifacts: FAILURE — Renovate could not update the vendor directory.

Root Cause

This is a major version bump changing the import path from gopkg.in/evanphx/json-patch.v4 to gopkg.in/evanphx/json-patch.v5. The PR only updates go.mod but does not update the vendor/ directory.

The old path gopkg.in/evanphx/json-patch.v4 is still required transitively by:

  • k8s.io/client-go (via vendor/k8s.io/client-go/testing/fixture.go)
  • sigs.k8s.io/controller-runtime (via vendor/sigs.k8s.io/controller-runtime/pkg/client/fake/client.go)

These transitive dependencies still import the v4 path, so simply bumping go.mod is insufficient — the old package cannot be removed from the vendor directory until its consumers are also updated.

Conclusion

This PR cannot be merged as-is. The vendor directory is inconsistent. This dependency is an indirect one pulled in by our k8s/controller-runtime stack — we should wait for upstream libraries to migrate to v5, or this update can be skipped/deferred. Recommend closing this PR for now.

@red-hat-konflux-kflux-prd-rh02
red-hat-konflux-kflux-prd-rh02 Bot force-pushed the konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x branch 17 times, most recently from b6d2791 to b2ec693 Compare August 14, 2026 12:24
@red-hat-konflux-kflux-prd-rh02
red-hat-konflux-kflux-prd-rh02 Bot force-pushed the konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x branch 10 times, most recently from 6a2ffe8 to 1b917b5 Compare August 17, 2026 20:21
@red-hat-konflux-kflux-prd-rh02
red-hat-konflux-kflux-prd-rh02 Bot force-pushed the konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x branch 12 times, most recently from a7d04c0 to 83f217e Compare August 24, 2026 12:38
@red-hat-konflux-kflux-prd-rh02
red-hat-konflux-kflux-prd-rh02 Bot force-pushed the konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x branch 5 times, most recently from f821fad to 3df96aa Compare August 28, 2026 08:20
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
@red-hat-konflux-kflux-prd-rh02
red-hat-konflux-kflux-prd-rh02 Bot force-pushed the konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x branch from 3df96aa to 6fc6eb0 Compare August 28, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants