Add AXSetMultiVoiceDeviceMix and update AXSetVoiceDeviceMix - #2050
Open
capitalistspz wants to merge 4 commits into
Open
Add AXSetMultiVoiceDeviceMix and update AXSetVoiceDeviceMix#2050capitalistspz wants to merge 4 commits into
AXSetMultiVoiceDeviceMix and update AXSetVoiceDeviceMix#2050capitalistspz wants to merge 4 commits into
Conversation
I may have edited them after testing
Exzap
reviewed
Sep 4, 2026
| return result; | ||
| } | ||
|
|
||
| sint32 AXSetMultiVoiceDeviceMix(AXVPBMULTI* mv, int32_t deviceType, int32_t deviceIndex, uint32_t busIndex, uint16_t vol, int16_t delta) |
By happenstance this also fixes the `deviceMix` display in the Audio Debugger
Exzap
reviewed
Sep 5, 2026
| for (auto voiceChannel = 0; voiceChannel < mv->channelCount; ++voiceChannel) | ||
| { | ||
| std::array<std::array<AXCHMIX2, AX_BUS_COUNT>, AX_TV_CHANNEL_COUNT> mix{}; | ||
| mix[voiceChannel][busIndex].vol = vol; |
Member
There was a problem hiding this comment.
voiceChannel (mv->channelCount) and busIndex should be bounds checked at the beginning of this function to prevent out of bounds access here. Maybe print a log line with LogType::APIErrors so that homebrew devs that use this incorrectly can see it in the log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on both the Wii U and Cemu with https://github.com/capitalistspz/wiiu_audio_examples/blob/master/2-play-stereo/main.c