Skip to content

Conversation

@aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Oct 2, 2025

Description

continue moving off web3 to viem

Other changes

Tested

existing

How to QA

ran commands

Related issues


PR-Codex overview

This PR primarily focuses on adding support for new contracts, specifically Reserve and SortedOracles, and updating the Parameters command to utilize a new method for fetching network configuration. It also introduces utility functions for managing time durations.

Detailed summary

  • Added Reserve and SortedOracles contracts with respective types and async functions.
  • Updated Parameters command to use getNetworkConfig instead of kit.getNetworkConfig.
  • Introduced utility functions for converting time durations in duration.ts.
  • Updated network configuration interfaces and methods to include new contracts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025

⚠️ No Changeset found

Latest commit: 55441e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aaronmgdr aaronmgdr changed the title Viem/params chore move network:params to viem Oct 2, 2025
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.40%. Comparing base (cfd9a5a) to head (55441e3).

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   69.63%   69.40%   -0.24%     
==========================================
  Files         150      152       +2     
  Lines        7071     7095      +24     
  Branches     1154     1158       +4     
==========================================
  Hits         4924     4924              
- Misses       2051     2078      +27     
+ Partials       96       93       -3     
Components Coverage Δ
celocli ∅ <ø> (∅)
sdk 69.15% <ø> (ø)
wallets 73.14% <ø> (ø)
viem-sdks 94.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

size-limit report 📦

Path Size
require('@celo/actions') (cjs) 98.85 KB (0%)
import * from '@celo/actions' (esm) 23.55 KB (0%)
import { resolveAddress } from '@celo/actions' (esm) 23.49 KB (0%)
import { getGasPriceOnCelo } from '@celo/actions' (esm) 73 B (0%)
import { getAccountsContract } from '@celo/actions/contracts/accounts' (esm) 46.11 KB (0%)
import * from '@celo/actions/staking' (esm) 50.66 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants