Skip to content

fix: respect Codex sandbox platform defaults#922

Open
cyrusagent wants to merge 2 commits intomainfrom
cypack-868
Open

fix: respect Codex sandbox platform defaults#922
cyrusagent wants to merge 2 commits intomainfrom
cypack-868

Conversation

@cyrusagent
Copy link
Copy Markdown
Contributor

@cyrusagent cyrusagent commented Mar 3, 2026

Assignee: @Connoropolous (connor)

Summary

  • Make Codex runner respect platform-provided sandbox defaults instead of forcing Cyrus defaults.
  • Keep explicit sandbox configuration behavior intact when users/repository config sets it.
  • Add targeted tests for implicit vs explicit sandbox behavior and document validation with an F1 test drive.

Implementation Approach

  • Updated CodexRunner.buildThreadOptions() to only pass sandboxMode when config.sandbox is explicitly provided.
  • Removed implicit sandbox_workspace_write override injection from CodexRunner.buildConfigOverrides().
  • Added coverage in CodexRunner.mcp-config.test.ts for:
    • no injected sandbox config when unset,
    • preserving explicit sandbox_workspace_write config,
    • no defaulted sandboxMode when unset,
    • forwarding explicit sandboxMode.

Testing Performed

  • pnpm --filter cyrus-codex-runner test:run (pass)
  • pnpm --filter cyrus-edge-worker exec vitest run test/AgentSessionManager.codex-runner-activity.test.ts test/EdgeWorker.runner-selection.test.ts (pass)
  • pnpm lint (pass)
  • pnpm typecheck (pass)
  • F1 protocol test drive documented at apps/f1/test-drives/2026-03-02-cypack-868-codex-sandbox-defaults-validation.md.

Breaking Changes / Migration Notes

  • None.

Linear Issue

@cyrusagent cyrusagent changed the title WIP: respect Codex sandbox platform defaults fix: respect Codex sandbox platform defaults Mar 3, 2026
@cyrusagent cyrusagent marked this pull request as ready for review March 3, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant