[draft] Updates Transitive closure algorithm (#1509)#2317
Draft
victornicolet wants to merge 4 commits intomainfrom
Draft
[draft] Updates Transitive closure algorithm (#1509)#2317victornicolet wants to merge 4 commits intomainfrom
victornicolet wants to merge 4 commits intomainfrom
Conversation
…existing transitive closure computation for only a sub-set of the overall nodes. Signed-off-by: Charlie Murphy <mutmoth@amazon.com>
Signed-off-by: Charlie Murphy <mutmoth@amazon.com>
… of a graph with cycles. More work needed to incorporate it in appropriate places. Signed-off-by: Charlie Murphy <mutmoth@amazon.com>
Signed-off-by: Victor Nicolet <victornl@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Picking up #1509 again with the hopes that the optimization on the transitive closure algorithm might yield significant benefits in some edge cases we've been encountering.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):