Conversation
Coverage ReportHead Commit: Base Commit: Download the full coverage report. Coverage of Added or Modified Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 100.00% Status: PASSED ✅ Details
Coverage of All Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 87.67% Status: PASSED ✅ Details
|
Signed-off-by: Victor Nicolet <victornl@amazon.com>
f0f19dd to
52af9a5
Compare
Coverage ReportHead Commit: Base Commit: Download the full coverage report. Coverage of Added or Modified Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 100.00% Status: PASSED ✅ Details
Coverage of All Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 87.67% Status: PASSED ✅ Details
|
|
I didn't make any changes to the existing TPE code, so you can just overwrite |
…et/pst-refinements
Coverage ReportHead Commit: Base Commit: Download the full coverage report. Coverage of Added or Modified Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 100.00% Status: PASSED ✅ Details
Coverage of All Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 87.66% Status: PASSED ✅ Details
|
Description of changes
This makes a few adjustments in the PST API:
try_into_pstnow suceeds even if there is no lossless representation. This allows usingtry_into_pstfor policies that are residuals from TPE (prior implementation would return an error). Eliminates an error type.PartialEqandEqto the PST types that were missing it,pstmodule, so that crates depending on Cedar don't have to add dependencies, or manage dependency version to match Cedar's.The last change is probably the one most worth discussing, but I think it makes the API cleaner.
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):