TPE: Guard against stack overflow#2298
Conversation
Signed-off-by: Lucas Käldström <lucas.kaldstrom@upbound.io>
Coverage ReportHead Commit: Base Commit: Download the full coverage report. Coverage of Added or Modified Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 75.00% Status: FAILED ❌ Details
Coverage of All Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 87.65% Status: PASSED ✅ Details
|
|
I didn't see any unit tests for this in the real evaluator, so do we add something to both places, or just ignore the coverage check for the modified lines? |
We probably didn't have the coverage checks when we added the guard to the evaluator, but I'm fine with leaving it uncovered. |
|
Cool, then we can merge this 👍 Does GitHub let us merge this even though one check is failing? 🤔 |
Description of changes
Broken out from #2162.
I noticed this mis-match in behavior between normal eval and partial eval, so adding the stack overflow guard to TPE as well.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I believe this is not covered by
cedar-spec?I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):