feat: Add help text for function argument validation errors#2291
Open
Vedthakar wants to merge 1 commit intocedar-policy:mainfrom
Open
feat: Add help text for function argument validation errors#2291Vedthakar wants to merge 1 commit intocedar-policy:mainfrom
Vedthakar wants to merge 1 commit intocedar-policy:mainfrom
Conversation
b741ca8 to
3ecaf9b
Compare
Coverage ReportHead Commit: Base Commit: Download the full coverage report. Coverage of Added or Modified Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 100.00% Status: PASSED ✅ Details
Coverage of All Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 87.56% Status: PASSED ✅ Details
|
Signed-off-by: Ved Thakar <ved06.thakar@gmail.com>
3ecaf9b to
d7326fe
Compare
john-h-kastner-aws
approved these changes
Apr 9, 2026
Contributor
john-h-kastner-aws
left a comment
There was a problem hiding this comment.
Looks good. Just one more possible tweak (if it works) and then you'll need to run cargo fmt
victornicolet
approved these changes
Apr 13, 2026
Contributor
|
Hi! I think this PR is good-to-go after once you push a quick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #834
This PR adds help text to
FunctionArgumentValidationErrorso validator errors for invalid extension function arguments include human-readable format guidance when available.Previously, these errors only surfaced a generic parse failure message. With this change, invalid arguments to extension functions such as
decimal,ip,datetime, anddurationcan now also include help text describing the expected input format.What changed
FunctionArgumentValidationErroripdecimaldatetimedurationThis directly addresses the request in #834 to make these validator errors more actionable by explaining what valid extension function inputs should look like.
Issue #, if available
Closes #834
Checklist for requesting a review
The change in this PR is:
cedar-policy(e.g., changes to the signature of an existing API).cedar-policy(e.g., addition of a new API).cedar-policy.cedar-policy-core,cedar-validator, etc.)I confirm that this PR:
I confirm that
cedar-spec:cedar-spec, and how you have tested that your updates are correct.)cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)I confirm that
docs.cedarpolicy.com:cedar-docs. PRs should be targeted at astaging-X.Ybranch, notmain.)