Description
In password.py line 29, if value: treats an empty string "" the same as "not set". This means VAULT_PASS="" falls through to the next source — potentially surprising behavior.
Proposed Solution
- Document this behavior in README.md and/or config reference
- Consider using
if value is not None: to distinguish between "not set" and "empty"
- Or keep current behavior but add a code comment explaining the choice
Files
src/vaultctl/password.py (line 29)
Priority
P2
Description
In
password.pyline 29,if value:treats an empty string""the same as "not set". This meansVAULT_PASS=""falls through to the next source — potentially surprising behavior.Proposed Solution
if value is not None:to distinguish between "not set" and "empty"Files
src/vaultctl/password.py(line 29)Priority
P2