Repository navigation
Fix unbound particle masking in haloquantity lookup - #233
Merged
Merged
Conversation
…lo quantities The unbound particle check in get_haloquantity_daskwrap compared against -1, but get_hidx marks unbound particles with index_unbound (int64 max by default). This caused unbound particles to be incorrectly looked up. Also adds support for 2D halo quantities (e.g. positions/velocities) via drop_axis/new_axis. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_haloquantity_daskwrap(was comparing against-1instead ofindex_unbound)index_unboundparameter through to the dask wrapperTest plan
🤖 Generated with Claude Code