Closed
Conversation
rarensu
force-pushed
the
don_t-panic
branch
from
84d3443 to
cd2d63a
Compare
Contributor
Author
|
Additionally, some of those functions had an unused |
Contributor
Author
|
To clarify, this PR branches from PR #401 . That one should be merged first. Update: it has been merged. |
Contributor
Author
|
To clarify, probably, the mutex lock will likely never actually ever become poisoned. There simply isn't any operation currently in use that can fail while holding the lock. So this error handling may never be reached. At least now the warning message in the code clearly demonstrates our intention is to ignore the error. |
…, and friends. This family of functions isn't actually capable of producing a meaningful `io` Error.
Instead, treating mount lock poison as a warning.
rarensu
force-pushed
the
don_t-panic
branch
from
cd2d63a to
23f5f96
Compare
Contributor
Clippy does not complain in CI, what's the issue? Poisoning and panicking seems to be correct behavior. But ignoring and (warning that will be buried in logs) on poison is more dangerous than panic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionUnmounterandBackgroundSessionhave unhandled.lock().unwrap()that causes clippy to complain that there should be a# Panicsection in the function documentation. I think it's more appropriate to handle the poison error, rather than panic.