Skip to content

Fix warning in catch_unique_ptr::bool() (fixes #3011) - #3012

Merged
horenmar merged 1 commit into
catchorg:develfrom
tim-lyon:patch-1
Aug 1, 2025
Merged

Fix warning in catch_unique_ptr::bool() (fixes #3011)#3012
horenmar merged 1 commit into
catchorg:develfrom
tim-lyon:patch-1

Conversation

@tim-lyon

@tim-lyon tim-lyon commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Description

Return boolean value instead of implicit conversion (as, for example, is done here)

GitHub Issues

Closes #3011

@codecov

codecov Bot commented Aug 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.90%. Comparing base (ccabd4d) to head (e41a1a9).
⚠️ Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3012   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files         201      201           
  Lines        8648     8648           
=======================================
  Hits         7861     7861           
  Misses        787      787           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@horenmar

horenmar commented Aug 1, 2025

Copy link
Copy Markdown
Member

Thanks

@horenmar
horenmar merged commit fbfd135 into catchorg:devel Aug 1, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning when compiling benchmarks using MSVC

2 participants