Revise transmission mappings#5263
Open
krivard wants to merge 34 commits into
Open
Conversation
For more information, see https://pre-commit.ci
krivard
commented
May 20, 2026
Comment on lines
+329
to
+332
| FUEL_CATEGORIES: dict[str, Path] = { | ||
| "categories": Path( | ||
| importlib.resources.files("pudl.package_data.ferc1") / "fuel_categories.yaml" | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
using explicit Path() here makes all these yaml categories entries consistent, but only the SUPPORTING_STRUCTURE ones are new in this PR
krivard
commented
May 20, 2026
| """ | ||
|
|
||
| PLANT_TYPE_CATEGORIES_HYDRO: dict[str, set[str]] = { | ||
| PLANT_TYPE_CATEGORIES_HYDRO: dict[str, dict[str, set[str]]] = { |
Contributor
Author
There was a problem hiding this comment.
unrelated opportunistic type hint correction
krivard
commented
May 20, 2026
Normalize column descriptions
* Set up a devcontainer for PUDL. * Simplify devcontainer pixi tasks * Add devcontainer section to dev_setup docs * Update devcontainer docs and release notes * Remove unnecessary setup in postCreateCommand * Apply suggestions from code review Co-authored-by: Kathryn Mazaitis <1158666+krivard@users.noreply.github.com> * Make coding agent usage of devcontainer obvious in docs --------- Co-authored-by: Kathryn Mazaitis <1158666+krivard@users.noreply.github.com>
krivard
commented
May 20, 2026
Comment on lines
+158
to
+161
| .. _ferc-structure-type-material: | ||
|
|
||
| Supporting Structure Types & Materials | ||
| -------------------------------------- |
Contributor
Author
There was a problem hiding this comment.
@zaneselvans looking especially for feedback on the source docs below; does this feel like it will give data users enough information to decide whether to use our type & materials columns vs doing that handling themselves? is it too much information?
i had originally planned to put the regexes in here too but chickened out (they are perhaps unsurprisingly not super legible). what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #4658
(really: brings #4859 into
main)What problem does this address?
@dd921 contributed a nice PR mapping
supporting_structure_typefree-form text to enums in #4859, but the mappings themselves needed a little QA zhuzh before we could deploy them in PUDL.What did you change?
Changes from #4859, plus:
supporting_structure_*_categories.ymlfiles updated with remaps from @zaneselvans and me (catalysters can view the extensive worksheet we used for labeling & analysis)Documentation
Make sure to update relevant aspects of the documentation:
docs/data_sources/templates).Testing
How did you make sure this worked? How can a reviewer verify this?
out_ferc1__yearly_transmission_lines_sched422and ancestors and verified no* uncategorized values warning appearedpixi run docs-buildand view results* okay it appears but the only values it flags are the empty string and the literal
n/aso that seems fine actuallyTo-do list
pixi run prek-runto run linters and static code analysis checks.pixi run pytest-cilocally to ensure that the merge queue will accept your PR.build-deploy-pudlGitHub Action manually and ensure that it succeeds.