Add detailed EIA-176 continuation-line tables#5245
Conversation
e-belfer
left a comment
There was a problem hiding this comment.
You're making great headway! Some requests for field changes and document updates, and a few questions.
Co-authored-by: E. Belfer <37471869+e-belfer@users.noreply.github.com>
|
Ok, so i currently have I'm thinking, however, maybe it would be better to unify those, like |
|
@MeadBarrel thanks for all of your work on this one! I think it's ready to go, but because it's such a big pr I've tagged @cmgosnell for secondary review. @cmgosnell Tagging you for secondary review, after alembic update and resolution of merge conflicts. |
Overview
Closes #5240.
What problem does this address?
EIA-176 continuation-line data includes useful detail behind several aggregate gas supply and disposition fields, but these records were only available in
raw_eia176__continuation_text_lines. This PR exposes the detailed records for imports, supplemental gaseous fuels, exports, and other disposition as core tables while preserving the existing aggregate disposition table.What did you change?
core_eia176__yearly_gas_imports,core_eia176__yearly_supplemental_gaseous_fuel_supplies,core_eia176__yearly_gas_exports, andcore_eia176__yearly_gas_disposition_other.core_eia176__yearly_gas_dispositionmetadata to point users to the new detailed exports and other-disposition tables.Documentation
Make sure to update relevant aspects of the documentation:
docs/data_sources/templates).src/metadata).Testing
Suggested reviewer checks:
pixi run --frozen pytest --no-cov test/unit/metadata_test.py::test_field_definitions test/unit/metadata_test.py::test_resource_descriptors_valid pixi run --frozen dg check defs --verbose pixi run dbt_helper validate --asset-select "key:core_eia176__yearly_gas_imports or key:core_eia176__yearly_supplemental_gaseous_fuel_supplies or key:core_eia176__yearly_gas_exports or key:core_eia176__yearly_gas_disposition_other"To-do list
dbttests.pixi run prek-runto run linters and static code analysis checks.pixi run pytest-cilocally to ensure that the merge queue will accept your PR.build-deploy-pudlGitHub Action manually and ensure that it succeeds.