Skip to content

Drop kubelinter #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anjmao wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop kubelinter #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5f120a
Drop kubelinter
anjmao Oct 21, 2025
ec221e2
Fix e2e
anjmao Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions cmd/controller/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (
"github.com/labstack/echo/v4/middleware"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promhttp"
"github.com/samber/lo"
"golang.org/x/sync/errgroup"
"golang.org/x/time/rate"
"google.golang.org/grpc"
Expand All @@ -28,7 +27,6 @@ import (
"github.com/castai/kvisor/cmd/controller/controllers"
"github.com/castai/kvisor/cmd/controller/controllers/imagescan"
"github.com/castai/kvisor/cmd/controller/controllers/kubebench"
"github.com/castai/kvisor/cmd/controller/controllers/kubelinter"
"github.com/castai/kvisor/cmd/controller/kube"
"github.com/castai/kvisor/pkg/blobscache"
"github.com/castai/kvisor/pkg/castai"
Expand Down Expand Up @@ -132,18 +130,6 @@ func (a *App) Run(ctx context.Context) error {
})
}

if cfg.Linter.Enabled {
linter, err := kubelinter.New(lo.Keys(kubelinter.LinterRuleMap))
if err != nil {
return err
}
linterCtrl := kubelinter.NewController(log, a.cfg.Linter, linter, castaiClient.GRPC)
kubeClient.RegisterKubernetesChangeListener(linterCtrl)
errg.Go(func() error {
return linterCtrl.Run(ctx)
})
}

if cfg.KubeBench.Enabled {
logsReader := kube.NewPodLogReader(clientset)
kubeBenchCtrl := kubebench.NewController(log, clientset, a.cfg.KubeBench, castaiClient.GRPC, logsReader, kubeClient, []string{})
Expand Down
2 changes: 0 additions & 2 deletions cmd/controller/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"github.com/castai/kvisor/cmd/controller/controllers"
"github.com/castai/kvisor/cmd/controller/controllers/imagescan"
"github.com/castai/kvisor/cmd/controller/controllers/kubebench"
"github.com/castai/kvisor/cmd/controller/controllers/kubelinter"
"github.com/castai/kvisor/pkg/castai"
)

Expand Down Expand Up @@ -35,7 +34,6 @@ type Config struct {
CastaiController controllers.CastaiConfig `json:"castaiController"`
CastaiEnv castai.Config `json:"castaiEnv"`
ImageScan imagescan.Config `json:"imageScan"`
Linter kubelinter.Config `json:"linter"`
KubeBench kubebench.Config `json:"kubeBench"`
JobsCleanup controllers.JobsCleanupConfig `json:"jobsCleanup"`
AgentConfig AgentConfig `json:"agentConfig"`
Expand Down
188 changes: 0 additions & 188 deletions cmd/controller/controllers/kubelinter/controller.go
View file
Open in desktop

This file was deleted.

78 changes: 0 additions & 78 deletions cmd/controller/controllers/kubelinter/controller_test.go
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions ...ller/controllers/kubelinter/customchecks/additionalcapabilities/additionalcapabilities.go
View file
Open in desktop

This file was deleted.

Loading
Loading