Skip to content

fix: only create lookup if CL is different #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyeotic merged 1 commit into from
Nov 4, 2025
Merged

fix: only create lookup if CL is different #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tempest2/src/main/kotlin/app/cash/tempest2/internal/TableSchemaFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,15 @@ object TableSchemaFactory {
// you to use a custom MethodHandles.Lookup instance, which is necessary when your
// application runs in an environment where your application code and dependencies
// like the AWS SDK for Java are loaded by different classloaders.
var methodHandle : MethodHandles.Lookup? = null;
var methodHandle : MethodHandles.Lookup = MethodHandles.lookup();
try {
// Try and use a handle that is scoped to the target class
methodHandle = MethodHandles.privateLookupIn(
clazz,
MethodHandles.lookup()
)
if (clazz.classLoader != TableSchemaFactory.javaClass.classLoader) {
// Try and use a handle that is scoped to the target class if the class is from a different ClassLoader
methodHandle = MethodHandles.privateLookupIn(
clazz,
MethodHandles.lookup()
)
}
} catch (_: Exception) {
// In some circumstances the above may fail, so fall back to the default behaviour
methodHandle = MethodHandles.lookup()
Expand Down
Loading