feat(ports): define JobStore + EventStream ports (§0.1)#6
Merged
Conversation
Define the two control-plane ports (§0.1 "define, don't implement") so the durable backends gated behind the second-replica trigger become a swap, not a rewrite. No app rewiring — the current Map/eventBus remain the impls. - ports/event-stream.ts: EventStream (publish/subscribe). EventBus now formally implements it (generic publish/subscribe alongside the job-event sugar), so the singleton eventBus IS the in-memory EventStream. - ports/job-store.ts: JobStore contract with tenant-partitioning (Caller) and owner/idempotency/wait-state seams already in the signatures; documented as the contract the current McpTaskManager Map satisfies de-facto. - Type-only port files excluded from coverage (like base.ts/runner.ts). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth §0.1 increment — "define, don't implement" the two control-plane ports so the durable backends (gated behind the second-replica trigger) become a drop-in swap.
What
ports/event-stream.ts—EventStream(publish/subscribe).EventBusnow implements it (generic publish/subscribe alongside the existing job-event sugar), so the singletoneventBusis the in-memory EventStream.ports/job-store.ts—JobStorecontract with the tenant-partitioning (Caller), owner/idempotency/wait-state seams already in the signatures; documented as the contract the currentMcpTaskManagerMap satisfies today.base.ts/runner.ts).Gates
typecheck✅ ·lint✅ ·test:coverage✅ (375 tests, 100%) ·build✅.🤖 Generated with Claude Code