DNM : Test/dep/secretgen v0.36 bump - #746
Open
sameerforge wants to merge 6 commits into
Open
Conversation
Signed-off-by: Sameer <sameer.khan@broadcom.com>
Signed-off-by: Sameer <sameer.khan@broadcom.com>
Signed-off-by: Sameer <sameer.khan@broadcom.com>
Adapt to breaking API changes in controller-runtime v0.24:
- Replace struct `&source.Kind{Type: obj}` + handler with function
`source.Kind[client.Object](cache, obj, handler)` and pass single
source to controller.Watch
- Replace `&handler.EnqueueRequestForOwner{OwnerType: ...}` struct with
`handler.EnqueueRequestForOwner(scheme, mapper, ownerType, opts...)`
function; update AttachWatches signature to accept manager.Manager
so cache/scheme/mapper are available
- Add context.Context first param to MapFunc signatures
- Update custom EventHandler methods (enqueueSecretExportToSecret,
enqueueDueToNamespaceChange) to use TypedRateLimitingInterface[Request]
- Remove deleted sigs.k8s.io/controller-runtime/pkg/ratelimiter import;
use workqueue.TypedRateLimiter[reconcile.Request] and
workqueue.DefaultTypedControllerRateLimiter / NewTypedItemExponentialFailureRateLimiter
- Update manager.Options: replace Namespace+MetricsBindAddress fields
with Cache.DefaultNamespaces and Metrics.BindAddress
- Fix tests: register status subresources on fake client builder and
clear TypeMeta from Secret comparisons (fake client no longer sets it)
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Daman Arora <daman.arora@broadcom.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- Update Dockerfile base image from golang:1.25.7 to golang:1.26 to match the go.mod requirement (k8s.io v0.36 requires Go 1.26) - Add missing godoc comments on exported AttachWatches methods in sharing reconcilers to satisfy the revive linter Signed-off-by: Daman Arora <daman.arora@broadcom.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Sameer <sameer.khan@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.