Conversation
Signed-off-by: Himanshu Singh <himansh.singh3@gmail.com>
himsngh
force-pushed
the
himsngh/fix-precommit-workflows-container-runtime
branch
from
September 15, 2026 08:32
27a9403 to
06f5172
Compare
nikhilsagotiya
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
CI pipelines (benchmarks, test-kctrl-gh, upgrade-testing) are failing randomly with a 404 page not found error during the kbld image building phase.
As GitHub Actions rolls out Ubuntu 24.04 runners, Minikube's default internal container runtime has shifted to containerd. When Minikube uses containerd, minikube docker-env relies on a highly experimental SSH proxy bridge. Docker Buildx (which kbld uses to build images) fails to communicate with its isolated moby/buildkit container across this SSH bridge, resulting in the daemon returning a 404 error.
Explicitly append --container-runtime=docker to all minikube start commands across the workflow files. This forces Minikube to use the legacy Docker engine internally, restoring the standard TCP socket communication for docker-env. This allows Buildx to use the native Docker driver without issue, resolving the pipeline flakiness.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
This is a tactical fix to immediately unblock the CI pipelines. As a long-term follow-up, we should look into removing the reliance on eval $(minikube docker-env) entirely across our test scripts. Refactoring the tests to build natively and push to a local registry will allow us to safely transition Minikube back to the containerd runtime without breaking Buildx.
Created an issue #1858
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: