feat: Support multi-letter identifiers in font groups - #54
Open
gjtorikian wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
gjtorikian
force-pushed
the
feat/multi-letter-identifiers
branch
from
May 23, 2026 20:29
faadd48 to
a80bee4
Compare
Owner
|
I'm still torn on this, I'll think about it more before we merge. |
…nto feat/multi-letter-identifiers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #45 by following the proposal in #45 (comment).
When the argument to a font-modifier command (
\mathrm,\mathit,\mathnormal, etc.) is a run of two-or-more ASCII alphabetic characters, this PR now emits a singleContent::Identifierevent so the renderer can produce one<mi>for the whole name. Non-alphabetic arguments still fall back to the per-character path.(In thinking about the breaking change noted in #51 (comment), I went around looking at issues where other breaking changes could be implemented, all at once.)