Fixed return value of the Map version #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the for loop finishes without returning false, it will always return true. Both strings have the same length at this point (if not, the function will return false at its beginning). So if a character exists in one string and not the other, count will be undefined, and the function will return false. The function will always return true if it finishes the for loop as the map size will be 0, so might as well return true (could be confusing as to why you have to return the map size).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the for loop finishes without returning false, it will always return true.
Both strings have the same length at this point (if not, the function will return false at its beginning).
So if a character exists in one string and not the other, count will be undefined, and the function will return false.
The function will always return true if it finishes the for loop as the map size will be 0, so might as well return true (could be confusing as to why you have to return the map size).