feat(react): migrate TagOverflow from carbon-for-ibm-products - #23160
Open
anamikaanu96 wants to merge 2 commits into
Open
feat(react): migrate TagOverflow from carbon-for-ibm-products#23160anamikaanu96 wants to merge 2 commits into
anamikaanu96 wants to merge 2 commits into
Conversation
✅ Deploy Preview for v12-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v12-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23160 +/- ##
==========================================
- Coverage 89.67% 89.62% -0.05%
==========================================
Files 639 643 +4
Lines 58865 59011 +146
Branches 8334 8308 -26
==========================================
+ Hits 52785 52888 +103
- Misses 5914 5956 +42
- Partials 166 167 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22930
Migrates the
TagOverflowcomponent fromcarbon-for-ibm-productsinto the Carbon core monorepo.Changelog
New
packages/react/src/components/TagOverflow/TagOverflow.tsx— component implementation with full TypeScript props interface (TagOverflowProps,TagOverflowItem)packages/react/src/components/TagOverflow/TagOverflowModal.tsx— modal sub-component for viewing all overflow tagspackages/react/src/components/TagOverflow/TagOverflowPopover.tsx— popover sub-component for inline overflow displaypackages/react/src/components/TagOverflow/constants.ts— sharedTYPESenum for tag type valuespackages/react/src/components/TagOverflow/index.ts— component barrel filepackages/react/src/components/TagOverflow/TagOverflow.stories.js— Storybook stories (Default, FiveTags, LongTags, UserAvatars, CustomComponents)packages/react/src/components/TagOverflow/TagOverflow.mdx— MDX docspackages/react/src/components/TagOverflow/story.scss— story-specific stylespackages/react/src/components/TagOverflow/utils.js— story fixtures and helpers (tag arrays, UserAvatar data, IconComponent)packages/react/src/components/TagOverflow/__tests__/TagOverflow-test.js— unit testse2e/components/TagOverflow/TagOverflow-test.avt.e2e.js— AVT e2e test skeleton (all tests usetest.skip()until v12 Storybook is live in CI)packages/styles/scss/components/TagOverflow/_tag-overflow.scss— component SCSS stylespackages/styles/scss/components/TagOverflow/_index.scss— SCSS indexpackages/react/scss/components/tag-overflow/_index.scss— forwarding stub indexpackages/react/scss/components/tag-overflow/_tag-overflow.scss— forwarding stubChanged
packages/react/src/internal/useOverflowItems.ts— extended to support the overflow measurement logic required by TagOverflow; fixedoffsetRefHandlerreturn type (HTMLElement | null) to match implementation and resolve TS2322packages/styles/scss/components/_index.scss—@use 'TagOverflow'added (commented with TODO until TagOverflow moves to stable)packages/react/src/index.ts— export block added (commented out with TODO for v12, with reminder to remove fromexcludeProductsComponents)packages/react/product-migrated-components.mjs—TagOverflow.stories.jsadded toproductMigratedStoryGlobsandsrc/components/TagOverflow/**/*added toexcludeProductsComponentsTesting / Reviewing
Run unit tests:
Start the v12 Storybook and verify the Preview/TagOverflow stories render correctly with all controls:
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide