fix: prevent loading overlay from stealing focus - #23152
Open
adamalston wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for v12-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v12-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23152 +/- ##
==========================================
- Coverage 89.67% 89.65% -0.02%
==========================================
Files 639 639
Lines 58865 58866 +1
Branches 8334 8335 +1
==========================================
- Hits 52785 52778 -7
- Misses 5914 5922 +8
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue. Related to #22196
Prevented active loading overlays from stealing focus from already focused page controls during navigation. Also prevented loading overlays behind modals from exposing a second modal dialog to assistive tech.
Changelog
Changed
aria-modal="true"from loading dialogs to avoid conflicting modal semantics when a loading overlay appears behind a modal.Testing / Reviewing
These changes fix the unexpected focus behavior introduced by 5d916f1, which may be considered a regression. I noticed issues after updating Carbon in one of the products I work on and seeing unexpected behavior related to
Loadingcomponents.Loading overlays should only claim focus when the document is focused on
body.Focus a page control, activate a
Loadingcomponent withwithOverlay, and verify that focus remains on the page control. Verify that focus trapping still works when focus moves outside the active overlay.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesFollowed therequired v12 migration documentation
for any code change that affects v12, or struck through this item because
the PR does not affect v12
More details can be found in the pull request guide