fix(combo-button): prevent hover from stealing focus - #23108
Open
arslansohail2001 wants to merge 4 commits into
Open
fix(combo-button): prevent hover from stealing focus#23108arslansohail2001 wants to merge 4 commits into
arslansohail2001 wants to merge 4 commits into
Conversation
✅ Deploy Preview for v12-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v12-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
All contributors have signed the DCO. |
arslansohail2001
force-pushed
the
fix/combo-button-focus
branch
from
August 25, 2026 09:09
b57d700 to
749774c
Compare
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
arslansohail2001
force-pushed
the
fix/combo-button-focus
branch
from
August 25, 2026 09:13
1959c69 to
f2546b4
Compare
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
arslansohail2001
force-pushed
the
fix/combo-button-focus
branch
from
August 25, 2026 09:16
c354222 to
8ac4947
Compare
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Arslan Sohail <arslansohail.2001@gmail.com>
arslansohail2001
force-pushed
the
fix/combo-button-focus
branch
from
August 25, 2026 09:26
8ac4947 to
4ced519
Compare
Author
|
I have read the DCO document and I hereby sign the DCO. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23108 +/- ##
==========================================
- Coverage 89.67% 89.65% -0.02%
==========================================
Files 639 639
Lines 58865 58865
Branches 8267 8267
==========================================
- Hits 52786 52778 -8
- Misses 5913 5921 +8
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamalston
reviewed
Aug 26, 2026
adamalston
left a comment
adamalston
left a comment
Contributor
There was a problem hiding this comment.
The issue linked in #23108 (comment) doesn't appear to exist.
https://github.com/carbon-design-system/carbon/issues/22831:
This issue has been deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22831
Fixes a bug where hovering over standard, non-submenu items in a
ComboButtonwould cause them to unexpectedly steal focus becauseuseHoverwas enabled on all items.Changelog
Changed
MenuItemto only enable theuseHoverhook if the item actually has children (i.e. is a submenu).ComboButton-test.jsto ensure that hovering over a standard item does not trigger focus stealing.Testing / Reviewing
ComboButtoncomponent.Alternatively, review the newly added regression test in
ComboButton-test.js.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examples(Not applicable)Followed the required v12 migration documentation for any code change that affects v12(Does not affect v12 migration documentation)