Merged
Conversation
anantadwi13
approved these changes
Jan 19, 2026
Contributor
anantadwi13
left a comment
anantadwi13
left a comment
There was a problem hiding this comment.
lgtm, but i have 1 question about the docker file
Contributor
|
thanks for the changes |
Contributor
|
anyway, could you attach some UI previews of this probe config? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for configurable liveness and readiness probes in Merlin model deployments, allowing users to customize probe parameters through both the UI and Python SDK. This enhancement provides users with fine-grained control over health check behavior for their model deployments
Modifications
Sending the Liveness and Readiness probes config values from the UI.
Backend API changes
Extended ResourceRequest model to support two new optional fields:
Updated deployment templating so provided probes are rendered into Kubernetes resources
Relevant areas:
UI changes
Added UI controls to configure liveness & readiness probe parameters.
Updated deployment details view to display saved probe configs after deployment (like CPU limits).
Python SDK
Added liveness and readiness probe configuration support to the Python SDK, enabling programmatic probe customization
Screenshot of Ui changes