Skip to content

[ui] clear backstack on messages tab change#368

Merged
capcom6 merged 1 commit into
masterfrom
ui/fix-messages-fragments-manaement
Jun 2, 2026
Merged

[ui] clear backstack on messages tab change#368
capcom6 merged 1 commit into
masterfrom
ui/fix-messages-fragments-manaement

Conversation

@capcom6
Copy link
Copy Markdown
Owner

@capcom6 capcom6 commented May 20, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved navigation stability when switching between outgoing and incoming message views by clearing prior child-view history before showing the selected pane, ensuring the chosen view displays consistently and preventing unexpected back-stack behavior.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 23999820-d9f7-4310-9901-feb047438537

📥 Commits

Reviewing files that changed from the base of the PR and between 8ccf2bd and a60c134.

📒 Files selected for processing (1)
  • app/src/main/java/me/capcom/smsgateway/ui/HolderFragment.kt

Walkthrough

HolderFragment now clears the child fragment back stack immediately (inclusive) before switching to outgoing or incoming child fragments; an import for FragmentManager enables POP_BACK_STACK_INCLUSIVE usage.

Changes

Child fragment back stack clearing

Layer / File(s) Summary
Child fragment back stack clearing on tab switch
app/src/main/java/me/capcom/smsgateway/ui/HolderFragment.kt
Import FragmentManager and add back stack clearing calls to selectOutgoing() and selectIncoming() before transitioning to the target fragment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: clearing the backstack when switching tabs on the messages UI. It directly corresponds to the code modification in HolderFragment.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ui/fix-messages-fragments-manaement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

🤖 Pull request artifacts

file commit
app-release.apk a60c134
app-release.aab a60c134
app-insecure.apk a60c134
app-insecure.aab a60c134

@capcom6 capcom6 added the ready label May 20, 2026
@capcom6 capcom6 force-pushed the ui/fix-messages-fragments-manaement branch from 5126e94 to 1ad8272 Compare May 22, 2026 00:44
@github-actions github-actions Bot removed the ready label May 22, 2026
@capcom6 capcom6 added the ready label May 24, 2026
@capcom6 capcom6 force-pushed the ui/fix-messages-fragments-manaement branch from 1ad8272 to 8ccf2bd Compare May 26, 2026 02:19
@github-actions github-actions Bot removed the ready label May 26, 2026
@capcom6 capcom6 added the ready label May 26, 2026
@capcom6 capcom6 force-pushed the ui/fix-messages-fragments-manaement branch from 8ccf2bd to a60c134 Compare May 29, 2026 01:22
@github-actions github-actions Bot removed the ready label May 29, 2026
@capcom6 capcom6 merged commit f7a1df5 into master Jun 2, 2026
4 checks passed
@capcom6 capcom6 deleted the ui/fix-messages-fragments-manaement branch June 2, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant