Fixed SplashScreen issues #201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The splash size was not fitting the window, now it's covering it rightly. Also, the splash screen were resizable, not now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The splash size was not fitting the window, now it's covering it rightly. For example, a splashscreen of 400x400 with an image of 400x400, or any same ratio was resizing the image so it was bigger than the window, zooming on it. An image with a different ratio of the splashscreen window would be resized without ratio to cover the entire window. Not this is fixed thanks modified css.
Also, the splash screen were resizable, which was a bit weird, it not longer be.